Discussion:
status of trunk in svn
christian bac
2008-04-17 09:03:10 UTC
Permalink
Hi,

I'm still trying to port our picoforge modules to trunk version.

I'm having, problem with ldap, and acl.
I have opened some files with eclipse and php plugin (using easy
eclipse).
Found a lot of typos and some real errors with eclipse warning.

And unguessable problem like an <<extra_fields>> variable in contact_sql
that I don't understand what it is supposed to be used for.

I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.

When will the resight tree changes be merged to trunk.

I have a good opportunity continue working on having picoforge modules
working well with the trunk version next month.
I don't want to waste my time fixing bugs already fixed elsewhere.
I would appreciate that trunk version is updated.

C.Bac
Olivier Berger
2008-04-17 16:53:53 UTC
Permalink
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
I have a good opportunity continue working on having picoforge modules
working well with the trunk version next month.
I don't want to waste my time fixing bugs already fixed elsewhere.
I would appreciate that trunk version is updated.
C.Bac
Reading you, I could understand it as "let me in, I want to be a
phpgroupware developper" ;)

Not trying to read Christian's mind, I promise, it was just to try and
wake up the list...

Regards,
--
Olivier BERGER <***@it-sudparis.eu> (*NEW ADDRESS*)
http://www-inf.it-sudparis.eu/~olberger/ - OpenPGP-Id: 1024D/6B829EEC
Ingénieur Recherche - Dept INF
Institut TELECOM / TELECOM & Management SudParis (http://www.it-sudparis.eu/), Evry
Dave Hall
2008-04-18 05:59:00 UTC
Permalink
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.

Cheers

Dave
Sigurd Nes
2008-04-18 22:26:24 UTC
Permalink
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
way - and the code needs manual tweaking before sync:

1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.

This is implemented in the resight tree as a check on the error-log-level - and
it would be very nice if the community - at least for now - could allow this
feature to survive.

2) We are working on a new template - as until yesterday was temporary named as
'newdesign' - some renaming - and it should be ok to sync across.

3) The structure is not identical in the two repos.

Regards

Sigurd
Dave Hall
2008-04-19 07:27:37 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
This is implemented in the resight tree as a check on the error-log-level - and
it would be very nice if the community - at least for now - could allow this
feature to survive.
2) We are working on a new template - as until yesterday was temporary named as
'newdesign' - some renaming - and it should be ok to sync across.
3) The structure is not identical in the two repos.
The question was when, not how or what. I think the community has a
right to know when to expect the bugs we (resight) introduced into the
tree will be fixed.

Cheers

Dave
Sigurd Nes
2008-04-19 09:09:39 UTC
Permalink
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
This is implemented in the resight tree as a check on the error-log-level - and
it would be very nice if the community - at least for now - could allow this
feature to survive.
2) We are working on a new template - as until yesterday was temporary named as
'newdesign' - some renaming - and it should be ok to sync across.
3) The structure is not identical in the two repos.
The question was when, not how or what. I think the community has a
right to know when to expect the bugs we (resight) introduced into the
tree will be fixed.
When: allow 1) - fix 2) and 3).

Regards

Sigurd
Dave Hall
2008-04-19 09:34:13 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
This is implemented in the resight tree as a check on the error-log-level - and
it would be very nice if the community - at least for now - could allow this
feature to survive.
2) We are working on a new template - as until yesterday was temporary named as
'newdesign' - some renaming - and it should be ok to sync across.
3) The structure is not identical in the two repos.
The question was when, not how or what. I think the community has a
right to know when to expect the bugs we (resight) introduced into the
tree will be fixed.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
Post by Sigurd Nes
- fix 2)
This is hardly a blocker, it has always been excluded from syncs. btw
any timeline on this?
Post by Sigurd Nes
and 3).
It is resight who chose a different tree structure. This is something
that we need to discuss internally, not here. It also doesn't prevent
any syncs.
Dr. Christian Böttger
2008-04-19 11:46:22 UTC
Permalink
Dave Hall schrieb:


| It is resight who chose a different tree structure. This is something
| that we need to discuss internally, not here. It also doesn't prevent
| any syncs.

sounds like "throwing the hot potatoe" around.. :-(

Doesn't help in the long run...

This adresses both parties - and perhaps more Sigurd than Dave

Just my 2¢

bofh42 aka CB

- --
***** Open Source und Linux im professionellen Einsatz *****
Dr. Christian Böttger (Dipl.Phys.) DF5OP Open Source Broker
EMail ***@gmail.com / ***@boettger.eu.com
http://www.böttger.info/ http://www.mydarc.de/df5op/
OpenBC: http://www.openbc.com/go/invuid/Christian_Boettger2
LinkedIn: https://www.linkedin.com/in/christianboettger
Dave Hall
2008-04-19 12:56:42 UTC
Permalink
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
| It is resight who chose a different tree structure. This is something
| that we need to discuss internally, not here. It also doesn't prevent
| any syncs.
sounds like "throwing the hot potatoe" around.. :-(
Doesn't help in the long run...
This adresses both parties - and perhaps more Sigurd than Dave
The structure of the SVN tree is an issue for ReSight, not phpGroupWare,
so I think it is an issue for us to discuss internally. It has no
impact on phpGroupWare. Also the structure isn't appropriate for
phpGroupWare.

If I (or anyone else) ever get the time we will implement the new
structure for phpGW's tree as discussed here
http://article.gmane.org/gmane.comp.web.phpgroupware.devel/6373

Cheers

Dave
Sigurd Nes
2008-04-21 15:55:38 UTC
Permalink
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
This is implemented in the resight tree as a check on the error-log-level - and
it would be very nice if the community - at least for now - could allow this
feature to survive.
2) We are working on a new template - as until yesterday was temporary named as
'newdesign' - some renaming - and it should be ok to sync across.
3) The structure is not identical in the two repos.
The question was when, not how or what. I think the community has a
right to know when to expect the bugs we (resight) introduced into the
tree will be fixed.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
Why not just allow the extra line of code in functions.inc.php:
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
Post by Dave Hall
Post by Sigurd Nes
- fix 2)
This is hardly a blocker, it has always been excluded from syncs. btw
any timeline on this?
Post by Sigurd Nes
and 3).
It is resight who chose a different tree structure. This is something
that we need to discuss internally, not here. It also doesn't prevent
any syncs.
Regards

Sigurd
Dave Hall
2008-04-22 14:22:37 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.

Cheers

Dave
Sigurd Nes
2008-04-23 07:58:55 UTC
Permalink
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.

Regards

Sigurd
Dave Hall
2008-04-23 06:08:06 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion

http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398

I don't think anything has changed since then.

Cheers

Dave
Dave Hall
2008-04-23 06:10:34 UTC
Permalink
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400

Cheers

Dave
Sigurd Nes
2008-04-23 18:51:11 UTC
Permalink
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.


Regards

Sigurd
Dave Hall
2008-04-23 21:10:43 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.
That is part of what was proposed back in January - keep in mind that it
is a complete solution to be implemented.

Cheers

Dave
Sigurd Nes
2008-04-24 06:08:32 UTC
Permalink
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.
That is part of what was proposed back in January - keep in mind that it
is a complete solution to be implemented.
Could we live with the check on ['global_level'] == 'N' in the meanwhile?
('N' is the default value)

Regards

Sigurd
Maât
2008-04-24 06:37:57 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.
That is part of what was proposed back in January - keep in mind that it
is a complete solution to be implemented.
Could we live with the check on ['global_level'] == 'N' in the meanwhile?
('N' is the default value)
Regards
Sigurd
honestly i can live with it and without it... i can even change it
myself if something goes wrong.

what i cannot do myself is merging the missing code into trunk so that
we can go on with phpgroupware

sorry to insist but compared to the whole project being locked down this
issue of having a var being set to whatever value you want seems incredible.

Let's merge this code with all the rest that's missing into trunk... if
something need to be adapted or optimized that can be adressed later ?

We are in trunk... so if that little part of the code brings drawbacks
we can have the very same debate in a few days with the code inside
trunk and the trunk ready for .18 testing and stabilization

my 2cts

Maât
Chris Weiss
2008-04-24 13:12:25 UTC
Permalink
Post by Maât
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.
That is part of what was proposed back in January - keep in mind that it
is a complete solution to be implemented.
Could we live with the check on ['global_level'] == 'N' in the meanwhile?
('N' is the default value)
Regards
Sigurd
honestly i can live with it and without it... i can even change it
myself if something goes wrong.
what i cannot do myself is merging the missing code into trunk so that
we can go on with phpgroupware
sorry to insist but compared to the whole project being locked down this
issue of having a var being set to whatever value you want seems incredible.
Let's merge this code with all the rest that's missing into trunk... if
something need to be adapted or optimized that can be adressed later ?
We are in trunk... so if that little part of the code brings drawbacks
we can have the very same debate in a few days with the code inside
trunk and the trunk ready for .18 testing and stabilization
my 2cts
Maât
I'm with maat on this one. this seems incredibly minor for a
development branch.

grant the code temporarily, we'll dispute how to deal with it later,
there are more important things to do.
Sigurd Nes
2008-04-24 13:33:12 UTC
Permalink
Sent: 2008-04-24 15:12:25 CEST
Subject: Re: [phpGroupWare-developers] status of trunk in svn
Post by Maât
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.
That is part of what was proposed back in January - keep in mind that it
is a complete solution to be implemented.
Could we live with the check on ['global_level'] == 'N' in the meanwhile?
('N' is the default value)
Regards
Sigurd
honestly i can live with it and without it... i can even change it
myself if something goes wrong.
what i cannot do myself is merging the missing code into trunk so that
we can go on with phpgroupware
sorry to insist but compared to the whole project being locked down this
issue of having a var being set to whatever value you want seems incredible.
Let's merge this code with all the rest that's missing into trunk... if
something need to be adapted or optimized that can be adressed later ?
We are in trunk... so if that little part of the code brings drawbacks
we can have the very same debate in a few days with the code inside
trunk and the trunk ready for .18 testing and stabilization
my 2cts
Maât
I'm with maat on this one. this seems incredibly minor for a
development branch.
grant the code temporarily, we'll dispute how to deal with it later,
there are more important things to do.
Great :)

Sigurd
Sigurd Nes
2008-04-24 16:50:09 UTC
Permalink
Post by Sigurd Nes
Sent: 2008-04-24 15:12:25 CEST
Subject: Re: [phpGroupWare-developers] status of trunk in svn
Post by Maât
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Dave Hall
Post by Sigurd Nes
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
When: allow 1)
Someone just needs to write the code which was proposed last time this
was discussed. I am sure the community would be happy to accept the
code when provided.
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}
This has been discussed in the past. The current code means developers
have to fix their code. It is in the trunk - not a stable branch. A
sustainable fix was proposed last time this was discussed, I am sure the
community would be happy to accept that code any time.
Has anyone looked at it?
The point is that it has to be simple to switch to and from debugging mode.
It was explored in depth back in January - here is the conclusion
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6398
Sorry the correct link is
http://thread.gmane.org/gmane.comp.web.phpgroupware.devel/6395/focus=6400
So display_errors set to off will suppress the notices from being displayed?
That's really in effect what I have been asking for.
That is part of what was proposed back in January - keep in mind that it
is a complete solution to be implemented.
Could we live with the check on ['global_level'] == 'N' in the meanwhile?
('N' is the default value)
Regards
Sigurd
honestly i can live with it and without it... i can even change it
myself if something goes wrong.
what i cannot do myself is merging the missing code into trunk so that
we can go on with phpgroupware
sorry to insist but compared to the whole project being locked down this
issue of having a var being set to whatever value you want seems incredible.
Let's merge this code with all the rest that's missing into trunk... if
something need to be adapted or optimized that can be adressed later ?
We are in trunk... so if that little part of the code brings drawbacks
we can have the very same debate in a few days with the code inside
trunk and the trunk ready for .18 testing and stabilization
my 2cts
Maât
I'm with maat on this one. this seems incredibly minor for a
development branch.
grant the code temporarily, we'll dispute how to deal with it later,
there are more important things to do.
Great :)
Sigurd
The code will be merged as soon as possible - in the meantime you can grab a
copy at http://www.byggeplass.bergen.no/download/phpgroupware.0.9.17.514_snap.tar.gz

The new template is here named as 'newdesign' -and will be renamed to 'portico'

It is possible that you have to do a 'register all hooks' to activate the new
menu-system.

Regards

Sigurd
Maât
2008-05-04 10:35:55 UTC
Permalink
Post by Sigurd Nes
The code will be merged as soon as possible - in the meantime you can grab a
copy at http://www.byggeplass.bergen.no/download/phpgroupware.0.9.17.514_snap.tar.gz
The new template is here named as 'newdesign' -and will be renamed to 'portico'
It is possible that you have to do a 'register all hooks' to activate the new
menu-system.
Regards
Sigurd
hi, i installed this version to check the differences... installation
look is better than .16 (there are remaining notice messages) and goes
toend nicely.

but when trying to display login page i have... nothing at all !

in apache error log i have this :

[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP Fatal error:
Call to undefined method mail_dcom::utf7_encode() in
/home/username/public_html/phpgroupware_resight/email/inc/class.mail_dcom_imap.inc.php
on line 218
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP Stack trace:
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 1. {main}()
/home/username/public_html/phpgroupware_resight/home.php:0
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 2.
parse_navbar() /home/username/public_html/phpgroupware_resight/home.php:121
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 3.
ExecMethod()
/home/username/public_html/phpgroupware_resight/phpgwapi/templates/idots/navbar.inc.php:35
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 4.
phpgwapi_menu->get()
/home/username/public_html/phpgroupware_resight/phpgwapi/inc/common_functions.inc.php:278
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 5.
phpgwapi_menu->load()
/home/username/public_html/phpgroupware_resight/phpgwapi/inc/class.menu.inc.php:56
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 6.
phpgwapi_hooks->process()
/home/username/public_html/phpgroupware_resight/phpgwapi/inc/class.menu.inc.php:87
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 7.
phpgwapi_hooks->single()
/home/username/public_html/phpgroupware_resight/phpgwapi/inc/class.hooks.inc.php:116
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 8.
ExecMethod()
/home/username/public_html/phpgroupware_resight/phpgwapi/inc/class.hooks.inc.php:179
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 9.
email_service->get_menu()
/home/username/public_html/phpgroupware_resight/phpgwapi/inc/common_functions.inc.php:278
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 10.
email_msg_bootstrap->ensure_mail_msg_exists()
/home/username/public_html/phpgroupware_resight/email/inc/class.service.inc.php:118
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 11.
mail_msg_base->begin_request()
/home/username/public_html/phpgroupware_resight/email/inc/class.msg_bootstrap.inc.php:226
[Sun May 04 12:33:32 2008] [error] [client 127.0.0.1] PHP 12.
mail_dcom->open()
/home/username/public_html/phpgroupware_resight/email/inc/class.mail_msg_base.inc.php:1436

is that "normal" ?

Maât
Sigurd Nes
2008-05-04 11:45:20 UTC
Permalink
Sent: 2008-05-04 12:35:55 CEST
Subject: Re: [phpGroupWare-developers] status of trunk in svn
Post by Sigurd Nes
The code will be merged as soon as possible - in the meantime you can grab a
copy at http://www.byggeplass.bergen.no/download/phpgroupware.0.9.17.514_snap.tar.gz
The new template is here named as 'newdesign' -and will be renamed to 'portico'
It is possible that you have to do a 'register all hooks' to activate the new
menu-system.
Regards
Sigurd
hi, i installed this version to check the differences... installation
look is better than .16 (there are remaining notice messages) and goes
toend nicely.
but when trying to display login page i have... nothing at all !
....lots of email related errors...
is that "normal" ?
email is a problem - when running through the menu-hook - it looks for a valid email-setup - which is not configured yet - and you get into trouble.

I know Dave has an eye on this issue - for now you need to leave out the email app - or remove the menu-hook for it.

It wouldn't hurt with a new pair of eyes - so if anyone has the energy - please dive in.

Also a comment on calendar: it is slightly more current in trunk at savanna (the latest commit)

Regards

Sigurd
Maât
2008-05-04 11:54:17 UTC
Permalink
Post by Sigurd Nes
Post by Maât
hi, i installed this version to check the differences... installation
look is better than .16 (there are remaining notice messages) and goes
toend nicely.
but when trying to display login page i have... nothing at all !
....lots of email related errors...
is that "normal" ?
email is a problem - when running through the menu-hook - it looks for a valid email-setup - which is not configured yet - and you get into trouble.
I know Dave has an eye on this issue - for now you need to leave out the email app - or remove the menu-hook for it.
It wouldn't hurt with a new pair of eyes - so if anyone has the energy - please dive in.
Also a comment on calendar: it is slightly more current in trunk at savanna (the latest commit)
Regards
Sigurd
ok.

Thank you for the answer Sigurd :)

Maât
Maât
2008-05-04 13:51:53 UTC
Permalink
Post by Sigurd Nes
email is a problem - when running through the menu-hook - it looks for a valid email-setup - which is not configured yet - and you get into trouble.
I know Dave has an eye on this issue - for now you need to leave out the email app - or remove the menu-hook for it.
It wouldn't hurt with a new pair of eyes - so if anyone has the energy - please dive in.
Also a comment on calendar: it is slightly more current in trunk at savanna (the latest commit)
Regards
Sigurd
Hi (again),

I uninstalled email and now i have login form displayed... i give admin
and password login info and i get... back to login page.

The login and password are correct and there are no more errors
displayed in apache error_log

:-(

Maât
Sigurd Nes
2008-05-05 03:51:00 UTC
Permalink
Post by Maât
Post by Sigurd Nes
email is a problem - when running through the menu-hook - it looks for a valid email-setup - which is not configured yet - and you get into trouble.
I know Dave has an eye on this issue - for now you need to leave out the email app - or remove the menu-hook for it.
It wouldn't hurt with a new pair of eyes - so if anyone has the energy - please dive in.
Also a comment on calendar: it is slightly more current in trunk at savanna (the latest commit)
Regards
Sigurd
Hi (again),
I uninstalled email and now i have login form displayed... i give admin
and password login info and i get... back to login page.
The login and password are correct and there are no more errors
displayed in apache error_log
Strange.

Did a quick test on the same code.
It worked for me - but it seems that $phpgw_info['server']['sessions_type'] is
not set in header.inc.php

Try setting this to either db or php

once you get in - you may want to change the template to 'newdesign'

Regards

Sigurd

Maât
2008-04-21 12:23:21 UTC
Permalink
Post by Sigurd Nes
Post by Dave Hall
Post by christian bac
I can propose diffs from my version and the trunk, but last time I did
it, skwashd talled that there were new versions in the <<resight tree>>,
that already had the same fixes.
When will the resight tree changes be merged to trunk.
This is a question for Sigurd to answer.
I'm glad to see that the activity is picking up, there has been very little of
it on savanna (except for ged) lately - and the sync has mostly moved code one
Well glad also to see that you're alive Sigurd... there have been
several posts on this list about meging evolutions from the famous
<<resight tree>>

we're all waiting for this deadlock to be solved to go on with .18
testing and stabilization.

I raised several issues on current svn trunk that need patching and i've
been answered that waiting for the merge was the best option
Post by Sigurd Nes
1) The resight project really need a method for quickly switch from
developer-mode to end-user mode - suspending the notices to be printed due to
frequently testing and demonstration of the system for non-developers.
This is implemented in the resight tree as a check on the error-log-level - and
it would be very nice if the community - at least for now - could allow this
feature to survive.
well such a feature seems rather a good thing than a bad one

but i can't see that as enough to delay the merge we are all waiting for.
Post by Sigurd Nes
2) We are working on a new template - as until yesterday was temporary named as
'newdesign' - some renaming - and it should be ok to sync across.
that's a nice thing but there again this can be adressed as a separate thing
Post by Sigurd Nes
3) The structure is not identical in the two repos.
what is the difference ? does it make merge processus harder than i
imagine ?

Maât
Loading...