svn trunk ... test needed ;)

[Benoit Hamet]

Hi all,

Sorry to be so long time out of the world, but I got some Health
problem, some work problem, etc ... Things looks a little bit better
now, So I take this day to work on trunk. My plans were to try to work
on ldap, but to do this, I need a running trunk :) Dohhh...

I juste read here the messages (after I commited my works, so too late
:). and see that some problems were already known. Anyway, I fixed some
of them, probably add some others, but at least, under pgsql, trunk is
installable in a "workable" manner.

When creating the admin user, it will have the rights to go to
administration app (which is the minimum).

Due to the new way locations are working, there's no more the
possibility to add acl to not yet installed applications ... So if you
don't want to take the time to go in administration after the full
setup, you will need to do :

step 1
step 2
step 3
step 4
step 2 bis (setting up users)

Note :

Many apps are not yet running, due to missing functions ... yeah I know.
I will fix them as long as I tests applications. Will take some time if
I'm alone. If not, it will be quicker. Please go for them. If you are
not sure of the way to fix them, please ask me (or/and Dave) before.
Don't expect our answer to come quickly, since as all of of you, we are
short on time.

If you plan to change the protected/private/public things that php5
enforce, please thing twice before commiting ... and ask around you before.

Regards.

Caeies, back on phpGW ...

[Maât]

Post by Benoit Hamet
Hi all,
Sorry to be so long time out of the world, but I got some Health
problem, some work problem, etc ... Things looks a little bit better
now, So I take this day to work on trunk. My plans were to try to work
on ldap, but to do this, I need a running trunk :) Dohhh...

WB Benoit :)

Post by Benoit Hamet
I juste read here the messages (after I commited my works, so too late
:). and see that some problems were already known. Anyway, I fixed some
of them, probably add some others, but at least, under pgsql, trunk is
installable in a "workable" manner.

Yesssss !

I love you Benoit :)

Post by Benoit Hamet
When creating the admin user, it will have the rights to go to
administration app (which is the minimum).

cool

Post by Benoit Hamet
Due to the new way locations are working, there's no more the
possibility to add acl to not yet installed applications ... So if you
don't want to take the time to go in administration after the full
step 1
step 2
step 3
step 4
step 2 bis (setting up users)
Many apps are not yet running, due to missing functions ... yeah I know.
I will fix them as long as I tests applications. Will take some time if
I'm alone. If not, it will be quicker. Please go for them. If you are
not sure of the way to fix them, please ask me (or/and Dave) before.
Don't expect our answer to come quickly, since as all of of you, we are
short on time.
If you plan to change the protected/private/public things that php5
enforce, please thing twice before commiting ... and ask around you before.
Regards.
Caeies, back on phpGW ...

I'm going to test and see if i need to patch ged :)

And i'll give a look at your commits to learn the good way to solve the
bugs.

Regards !

[Giorgio Pioda]

Nice,

I've tried to install truk last week but I got only bunch of errors triing to login after a successful installation...

I'll checkout tonight and test again.

cheers

gfwp.

Sent from the phpGroupWare forums @ forums.phpGroupWare.org

[Maât]

Post by Benoit Hamet
Hi all,

Hi Benoit,

I updated trunk and played : install is now working nicely !

Very cool news :)

I have an ugly call to protected method
phpgwapi_config::read_repository() in ged that i need to patch :-(


2 Problems found :

1) Trying to reinstall cause SQL error (duplicate sql error at insert
for admin 1000 account)

2) Call to undefined method phpgwapi_accounts_sql::get_account_name() in
...phpgroupware/phpgwapi/inc/class.common.inc.php on line 497

Regards,
Maât

[Dave Hall]

Post by Maât
I have an ugly call to protected method
phpgwapi_config::read_repository() in ged that i need to patch :-(

Use read() that is the public method which reads the config data. This
was documented in several commit messages too.

Post by Maât
1) Trying to reinstall cause SQL error (duplicate sql error at insert
for admin 1000 account)

What do you mean by reinstall? Which db?

Post by Maât
2) Call to undefined method phpgwapi_accounts_sql::get_account_name() in
...phpgroupware/phpgwapi/inc/class.common.inc.php on line 497

As mentioned to you on irc, you just need to caste the account object
for this functionality. btw I fixed it in svn, was pretty easy to do -
see r19003.

Cheers

Dave

[Maât]

Post by Dave Hall

Post by Maât
I have an ugly call to protected method
phpgwapi_config::read_repository() in ged that i need to patch :-(

Use read() that is the public method which reads the config data. This
was documented in several commit messages too.

Yeah i saw and i learned from it. I understand now what you said about
my ugly hack.

Post by Dave Hall

Post by Maât
1) Trying to reinstall cause SQL error (duplicate sql error at insert
for admin 1000 account)

What do you mean by reinstall? Which db?

Well i must admit i did not myself very clear. Let me try to do better :

I had a phpgw database installed from the previous tries i did with my
ugly hacks.

I ran setup, proceeded to full uninstall then ran through install
process (database install, chack again, setup, app install, and last
sysadmin creation).

I had the problem on this last step.

Dropping and re-creating manually the database then trying again to go
through the whole install problem gave me a fully ok installed phpgw

Post by Dave Hall

Post by Maât
2) Call to undefined method phpgwapi_accounts_sql::get_account_name() in
...phpgroupware/phpgwapi/inc/class.common.inc.php on line 497

As mentioned to you on irc, you just need to caste the account object
for this functionality. btw I fixed it in svn, was pretty easy to do -
see r19003.
Cheers
Dave

Thank you very much Dave :)

[Dave Hall]

Post by Maât

Post by Dave Hall
What do you mean by reinstall? Which db?

I had a phpgw database installed from the previous tries i did with my
ugly hacks.
I ran setup, proceeded to full uninstall then ran through install
process (database install, chack again, setup, app install, and last
sysadmin creation).
I had the problem on this last step.
Dropping and re-creating manually the database then trying again to go
through the whole install problem gave me a fully ok installed phpgw

Looks like you have found a bug to track down :) I suspect that the
accounts table isn't being properly cleared on uninstall. phpgwapi
isn't an application, so that could be causing the problem. I am sorry
I have very limited time over the next 2 weeks for bug hunting I have a
client project going live very soon. I will try to answer queries you
have.

Cheers

Dave

[b***@laposte.net]

Hi all,

Post by Dave Hall

Post by Maât
I have an ugly call to protected method
phpgwapi_config::read_repository() in ged that i need to patch :-(

Use read() that is the public method which reads the config data. This
was documented in several commit messages too.

And in most cases this call is not needed for some functions ... (that's not the case of phpgwapi_config afaik)

Post by Dave Hall

Post by Maât
1) Trying to reinstall cause SQL error (duplicate sql error at insert
for admin 1000 account)

What do you mean by reinstall? Which db?

Post by Maât
2) Call to undefined method phpgwapi_accounts_sql::get_account_name() in
...phpgroupware/phpgwapi/inc/class.common.inc.php on line 497

As mentioned to you on irc, you just need to caste the account object
for this functionality. btw I fixed it in svn, was pretty easy to do -
see r19003.

Well, that's not the solution in all cases. The main stumbling block is the display of the user name for example, which is chosen to be either the username or the fullname ... this is used in the display_name function and not so easy to fix ...

Regards,

Benoît.

Créez votre adresse électronique ***@laposte.net
1 Go d'espace de stockage, anti-spam et anti-virus intégrés.

[Dave Hall]

Post by Maât

Post by Dave Hall

Post by Maât
2) Call to undefined method

phpgwapi_accounts_sql::get_account_name() in

Post by Dave Hall

Post by Maât
...phpgroupware/phpgwapi/inc/class.common.inc.php on line 497

As mentioned to you on irc, you just need to caste the account

object

Post by Dave Hall
for this functionality. btw I fixed it in svn, was pretty easy to do

-

Post by Dave Hall
see r19003.

Well, that's not the solution in all cases. The main stumbling block
is the display of the user name for example, which is chosen to be
either the username or the fullname ... this is used in the
display_name function and not so easy to fix ...

The caste will respect the users preference and render the full name in
the desired format. For the username (which shouldn't be used any where
except in admin) it is a public instance variable of the account object
( for example $GLOBALS['phpgw']->accounts->get($id)->lid )

Cheers

Dave