Code available for test

[Sigurd Nes]

The email app is updated and seems to work.

Fresh code is available for testing at:

http://www.byggeplass.bergen.no/download/phpggroupware_17524_nov_22.tar.gz


Modules:
* addressbook
* admin
* calendar
* email
* hrm
* manual
* messenger
* notes
* preferences
* (projects - well - kind of)
* property
* sms
* todo


Regards

Sigurd

[Sigurd Nes]

Post by Sigurd Nes
The email app is updated and seems to work.
XXX

Old one is removed.

Post by Sigurd Nes
* addressbook
* admin
* calendar
* email
* hrm
* manual
* messenger
* notes
* preferences
* (projects - well - kind of)
* property
* sms
* todo

There is a new one:
http://www.byggeplass.bergen.no/download/phpggroupware_17524_nov_23.tar.gz

Fixes to the email app:
File attachment, spell checker and search



Regards

Sigurd

[Maât]

Post by Sigurd Nes

Post by Sigurd Nes
The email app is updated and seems to work.
XXX

Old one is removed.

Post by Sigurd Nes
* addressbook
* admin
* calendar
* email
* hrm
* manual
* messenger
* notes
* preferences
* (projects - well - kind of)
* property
* sms
* todo

http://www.byggeplass.bergen.no/download/phpggroupware_17524_nov_23.tar.gz
File attachment, spell checker and search
Regards
Sigurd

wow...

subversion log living again :)

just one question (i'm curious) do subversion repos and this tar.gz
contain the same code ?

if no which one is ahead ?

[Sigurd Nes]

Sent: 2009-11-24 00:00:53 CET
Subject: Re: [phpGroupWare-developers] Code available for test

Post by Sigurd Nes

Post by Sigurd Nes
The email app is updated and seems to work.
XXX

Old one is removed.

Post by Sigurd Nes
* addressbook
* admin
* calendar
* email
* hrm
* manual
* messenger
* notes
* preferences
* (projects - well - kind of)
* property
* sms
* todo

http://www.byggeplass.bergen.no/download/phpggroupware_17524_nov_23.tar.gz
File attachment, spell checker and search
Regards
Sigurd

wow...
subversion log living again :)
just one question (i'm curious) do subversion repos and this tar.gz
contain the same code ?
if no which one is ahead ?

It is identical (to the date) - it's just to spare peopel of having to deal with svn:externals.

email is from phpgroupware/modules/email/trunk - the rest is from phpgroupware/people/sigurdne...

(I took the liberty of tuning the email-app directly without going via the personal repository - as this is minor fixes)

Regards

Sigurd

[Maât]

Post by Sigurd Nes

Post by Maât
wow...
subversion log living again :)
just one question (i'm curious) do subversion repos and this tar.gz
contain the same code ?
if no which one is ahead ?

It is identical (to the date) - it's just to spare peopel of having to deal with svn:externals.

Wooohooo ! Then i can test it with a checkout and compare trees \o/

Thanks :)

Post by Sigurd Nes
email is from phpgroupware/modules/email/trunk - the rest is from phpgroupware/people/sigurdne...
(I took the liberty of tuning the email-app directly without going via the personal repository - as this is minor fixes)

I looked at the patches... yeah they all seem minor and positive fixes
so no problem for me.


May i just suggest something for the future ?

I'd like we all think about commit log standardization so that we have
more presision and the possibility to create changelogs automatically later.

I's suggest for example something like a beginning tag

Bug fix : <-- patche that fix wrong code
Security fix : <-- obvious isn't it ? :)
Code formatting : <-- this one just for indentation and other chenges
that do not change the code
Code cleaning : <-- this one for php modernization and other changes
that do change the code but do not change the resulting behavior
New feature : <-- this one new cool feature
...

(we would of course need to define the precise list of possible tags)

And i'd suggest that a commit concerns only one specific point

for example i'd rather have seen change set [20890] Fix search (not
happy with non-ascii) splitted in two :

-- one for the php code modernization :
Code cleaning : changing from $GLOBALS['HTTP_POST_VARS'] to $_POST and
removing trailing ?>

-- One for the real fixing part :
Bug fix : Fix search problem with non-ascii


That suggestion is not supposed to be taken "as it is" but rather to be
the start point of a common work to improve it so that we end with
some nice rules for svn management :)


(Btw i did not understand this non-ascii problem by just reading your
changes... would you mind to explain the problem and the fix to me please ?)


Best regards,
Maât

[Sigurd Nes]

Sent: 2009-11-24 10:14:29 CET
Subject: Re: [phpGroupWare-developers] Code available for test

Post by Sigurd Nes

Post by Maât
wow...
subversion log living again :)
just one question (i'm curious) do subversion repos and this tar.gz
contain the same code ?
if no which one is ahead ?

It is identical (to the date) - it's just to spare peopel of having to deal with svn:externals.

Wooohooo ! Then i can test it with a checkout and compare trees \o/
Thanks :)

Post by Sigurd Nes
email is from phpgroupware/modules/email/trunk - the rest is from phpgroupware/people/sigurdne...
(I took the liberty of tuning the email-app directly without going via the personal repository - as this is minor fixes)

I looked at the patches... yeah they all seem minor and positive fixes
so no problem for me.
May i just suggest something for the future ?
I'd like we all think about commit log standardization so that we have
more presision and the possibility to create changelogs automatically later.
I's suggest for example something like a beginning tag
Bug fix : <-- patche that fix wrong code
Security fix : <-- obvious isn't it ? :)
Code formatting : <-- this one just for indentation and other chenges
that do not change the code
Code cleaning : <-- this one for php modernization and other changes
that do change the code but do not change the resulting behavior
New feature : <-- this one new cool feature
...
(we would of course need to define the precise list of possible tags)
And i'd suggest that a commit concerns only one specific point
for example i'd rather have seen change set [20890] Fix search (not
Code cleaning : changing from $GLOBALS['HTTP_POST_VARS'] to $_POST and
removing trailing ?>
Bug fix : Fix search problem with non-ascii
That suggestion is not supposed to be taken "as it is" but rather to be
the start point of a common work to improve it so that we end with
some nice rules for svn management :)
(Btw i did not understand this non-ascii problem by just reading your
changes... would you mind to explain the problem and the fix to me please ?)

The search didn't work at all - now it works at least with ascii.
Tried to play with different encoding - like imap_utf7_encode() to the criteria applied to imap_search - but no luck.
Maybe you can have a go at it?
The actual search is performed in class.mail_dcom_imap.inc.php, function: i_search() around line 243.

The only (other) thing (I think) remaining - is the filter feature - seems like a object wasn't initialized....

Maybe you can see at it with fresh eyes?

Regards

Sigurd

[Maât]

Post by Sigurd Nes

Post by Maât
(Btw i did not understand this non-ascii problem by just reading your
changes... would you mind to explain the problem and the fix to me please ?)

The search didn't work at all - now it works at least with ascii.

ok :)

that's why i did not see code that looked like something that does deal
with ascii/non-ascii problems :)

Post by Sigurd Nes
Tried to play with different encoding - like imap_utf7_encode() to the criteria applied to imap_search - but no luck.
Maybe you can have a go at it?
The actual search is performed in class.mail_dcom_imap.inc.php, function: i_search() around line 243.
The only (other) thing (I think) remaining - is the filter feature - seems like a object wasn't initialized....
Maybe you can see at it with fresh eyes?

yep... that can not bring harm if i give it a look just in case :)